feat: Add ones primitive #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 88.72% 88.73% +0.01%
==========================================
Files 75 75
Lines 17374 17395 +21
==========================================
+ Hits 15415 15436 +21
Misses 1959 1959
🚀 New features to boost your workflow:
|
norhan-synnada
approved these changes
Mar 10, 2025
| super().__init__( | ||
| formula_key="ones", | ||
| name=name, | ||
| output=BaseKey(shape=[("Var", ...)], type=Tensor), |
There was a problem hiding this comment.
No need to indicate shape if it is Variadic
| ignore_transform={"shape"}, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
we can add randomized tests for this model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #226
What is Changed
Checklist: